Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid passing private flags from pmake #1334

Closed
wants to merge 1 commit into from

Conversation

jbergstroem
Copy link
Member

pmake introduces private flags (-J) when passing certain arguments to it (such as -j). Filter these out before passing to gmake.

/R=@iojs/platform-freebsd

pmake introduces private flags (-J) when passing certain arguments
to it (such as -j). Filter these out before passing to gmake.
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Apr 3, 2015
@indutny
Copy link
Member

indutny commented Apr 3, 2015

LGTM, if it works.

jbergstroem added a commit that referenced this pull request Apr 3, 2015
pmake introduces private flags (-J) when passing certain arguments
to it (such as -j). Filter these out before passing to gmake.

PR-URL: #1334
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@jbergstroem
Copy link
Member Author

Thanks. Merged in 6a134f7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants